Review of actions from previous meeting
Actions from last time, and their status are:
- Daniel and Lars to keep an eye on the FOSDEM CfP (30th Nov) and together decide if/where to submit a talk.
- we had a preview of the CFP for the “safety and open source” devroom
- there’s no deadline for the CFP responses yet, but we’d like to submit our proposal early, within a week
- we’ll need to have a title, subtitle, one-paragraph abstract, an optional longer description, and some relevant links
Review of the iteration that has ended
Subplot milestone 40 had the following issued closed:
- Subplot issue 180 Doesn’t warn about unused embedded files
- Subplot issue 198 Unify language handling for multi-impl-lang test suites
- Subplot issue 241 ./check doesn’t build/test all of the workspace
- Subplot issue 242
subplotlib
doesn’t usebuild.rs
script
Additionally, we upped the Minimum Supported Rust Version to 1.56 (Subplot issue 258).
We made little progress on:
- Subplot issue 133 No feature table comparing scenario runners from different codegen templates
- Subplot issue 218 Automatable parts of release process are manual
- Subplot issue 253 Make release 0.3.2 or 0.4.0 of Subplot
- Subplot issue 221 Command line tool has insufficient logging
- Subplot issue 214 Lacks example and docs for using Rust step functions
We made significant progress on:
- Subplot issue 141 subplotlib: Needs better test suite
- Daniel did what he meant to do, but it’s a tracking issue, and he opened a new blocker issue
We moved most of the remaining open issues to the next milestone (Subplot milestone 41) and then closed off this iteration.
Review of the repositories
Currently open MRs:
subplot
: nonesubplot-web
: nonesubplot-container-images
: none
Extra branches unrelated to MRs:
subplot
:subplot-rust
– Daniel is keeping this around until he has completed the work on Subplot issue 141.docgen-cmark
– Lars is working on making docgen use cmark rather than pandoc for the initial parse and processing.
subplot-web
: nonesubplot-container-images
: none
Pipelines:
subplot
: cleansubplot-web
: nonesubplot-container-images
: clean, and we triggered the one to build a new container image
Current goal (goal 2; not changed for this iteration)
Subplot provides a set of libraries with identical capabilities in each of the supported languages. Python remains a supported language. Rust is promoted to supported-language status. Subplot will be tested with all supported languages. In addition, any quality of life improvements which can be done shall be done. This goal will be considered complete when a release of Subplot has been made with the unified language handling support complete.
Length of this iteration
The year-end holidays are coming, so we decided to make this a month-long iteration. The next planned meeting is January 1.
Issue review
We had 51 open issues at the start of the meeting.
We reviewed non-someday-maybe
issues for subplot
that have been changed since thee previous meeting.
We made the following changes:
- Subplot issue 214 Lacks example and docs for using Rust step functions
- put into iteration
- assigned to Lars
- Subplot issue 251 and Subplot issue 252 will probably go away now that our MSRV has been raised
- Subplot issue 255 __
- uses of the word graph exposed to users should change, but it’s not urgent
- we adjusted labels
- Subplot issue 256 Lacks way to mark an embedded file as being OK that it’s not used in a scenario
- adding
.example
that’s like.file
, with the same typesetting, but that can’t be used as an embedded file is probably the way to go - adjusted labels
- adding
- Subplot issue 259 Top level subplots should be run in Rust too
- put into iteration
- assigned to Daniel
- adjusted labels
We left the docker-for-subplot issue alone, and subplot-web had no issues.
Other discussion
- We had a discussion and agreed that goal 2 doesn’t need significant QoL changes right now. We may drop of the issues currently assigned to goal 2.
Plan for next iteration
We opened Subplot milestone 41 to cover this iteration, with the following issues:
- Subplot issue 133 No feature table comparing scenario runners from different codegen templates
- Subplot issue 141 subplotlib: Needs better test suite
- Subplot issue 207 Release process is too manual, CI build of release .deb changes files
- Subplot issue 214 Lacks example and docs for using Rust step functions
- Subplot issue 218 Automatable parts of release process are manual
- Subplot issue 220 Generated Rust test programs are hard to debug
- Subplot issue 221 Command line tool has insufficient logging
- Subplot issue 250 subplotlib could do with unit tests
- Subplot issue 251 We depend on a vulnerable version of chrono
- Subplot issue 252 We transitively depend on a vulnerable version of time
- Subplot issue 254 Make release 0.3.2 or 0.4.0 of Subplot
- Subplot issue 259 Top level subplots should be run in Rust too
Other business
We decided to make a release of whatever is in the
main
branch and label it 0.3.2 or 0.4.0, depending on whether it has breaking changes or not. Subplot issue 254We are not yet ready to file an RFP bug to get Subplot packaged for Debian. It will happen after we think we won’t be making breaking changes anymore. We probably want to do a review of the dependencies as well, to make packaging easier.
We are not yet ready to make a whole code base review of Subplot. However we feel at least part of the new goal 3 will be reviewing a portion of the code. Lars made the
pandoc-filter-diagram
crate from Subplot code, and intends to refactor Subplot to use it eventually.We will switch an issue based agenda when other people join the meeting.
We won’t be reaching out for feedback until goal 3 is done.
We’ll aim at the FOSDEM “safety and open source” devroom for now. After we’ve made that talk, whether it’s accepted or not, we will consider other conferences and also podcasts.
Regarding the
media
repository question - we believe this is premature at this point - once we are ready to write the talk mentioned above, it will be time for the repository.Lars will be opening communications with the WMF around supporting their use of Subplot for
scap
.
Actions
Lars will open an issue to use pandoc-filter-diagram.
Lars will approach WMF about how
scap
uses Subplot.